Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid E231 missing whitespace after ':' with Python 3.12 #1845

Closed
grische opened this issue Jul 18, 2023 · 2 comments
Closed

Invalid E231 missing whitespace after ':' with Python 3.12 #1845

grische opened this issue Jul 18, 2023 · 2 comments

Comments

@grische
Copy link

grische commented Jul 18, 2023

how did you install flake8?

$ python -m pip install flake8 poetry

See https://github.com/grische/extremeflash/actions/runs/5585322641/jobs/10207909510?pr=3

unmodified output of flake8 --bug-report

{
  "platform": {
    "python_implementation": "CPython",
    "python_version": "3.12.0b4",
    "system": "Linux"
  },
  "plugins": [
    {
      "plugin": "mccabe",
      "version": "0.7.0"
    },
    {
      "plugin": "pycodestyle",
      "version": "2.10.0"
    },
    {
      "plugin": "pyflakes",
      "version": "3.0.1"
    }
  ],
  "version": "6.0.0"
}

describe the problem

See https://github.com/grische/extremeflash/actions/runs/5585322641/jobs/10207909510?pr=3

what I expected to happen

Only the Python 3.12 run shows this error, while Python 3.10 and Python 3.11 succeed successfully.
Expecting to also pass for Python 3.12

sample code

https://github.com/grische/extremeflash/blob/b8419e6bc283cfcd3052f054961ba977d9d3aec4/extremeflash/tftp_server.py#L27-L32

commands ran

flake8 . --count --show-source --statistics
./extremeflash/tftp_server.py:28:63: E231 missing whitespace after ':'
        logging.info(f"Starting tftp server on {self.listenip}:{self.port} from {self.tmpdir}")
                                                              ^
1     E231 missing whitespace after ':'
1
@sigmavirus24
Copy link
Member

Please re-read the issue template. Flake8 does not implement any checks.

@sigmavirus24 sigmavirus24 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 18, 2023
@alexwlchan
Copy link

For anybody else who lands here: this issue occurs in pycodestyle 2.10.0 but is fixed by upgrading to pycodestyle 2.11.0.

(Which was the first version of pycodestyle to support Python 3.12.)

@PyCQA PyCQA deleted a comment from leopepe Nov 7, 2023
@PyCQA PyCQA locked as spam and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants