Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags on the default branch #1371

Closed
hugovk opened this issue Aug 7, 2020 · 2 comments
Closed

Tags on the default branch #1371

hugovk opened this issue Aug 7, 2020 · 2 comments
Labels
integration question Further information is requested

Comments

@hugovk
Copy link
Contributor

hugovk commented Aug 7, 2020

I'm using isort with pre-commit, and use the pre-commit autoupdate command to update to the latest versions of isort and other tools.

However, it's not picking up today's 5.3.1 or 5.3.2. And strangely, if I manually set it to 5.3.2, autoupate resets it to 5.3.0.

This is because (pre-commit/pre-commit#1555 (comment)):

yeah, isort doesn't tag their default branch or merge their tags into the default branch for some reason

pre-commit autoupdate picks the latest tag on the main branch

Would it be possible to tag the default branch, or merge the tags into it so the tools play nicely with each other?

It's great to see regular releases here, and thank you for all your work!

@timothycrosley
Copy link
Member

Hi @hugovk, Thanks for pinging me!

I've merged in the latest tags into the default branch so that pre-commit will pick them up. Precommit's behaviour of insisting on using the default branch (which is the one meant for PRs and therefore generally develop or unstable) is unintuitive for me, so I never guessed this would be a requirement! I'll make sure to include merging back into develop as a release checklist item from now on.

Thanks!

~Timothy

@timothycrosley timothycrosley added integration question Further information is requested labels Aug 8, 2020
@hugovk
Copy link
Contributor Author

hugovk commented Aug 8, 2020

Thank you, confirmed working as expected now! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants