Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore hidden directories by default #1460

Closed
tobiasherp opened this issue Sep 4, 2020 · 1 comment
Closed

Ignore hidden directories by default #1460

tobiasherp opened this issue Sep 4, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@tobiasherp
Copy link

I just gave isort a first try and used it in a clean svn working directory. I noticed that changes were applied to Python files below the .svn directory path. In my case, I was able to recover easily by trashing the working copy and check it out again; but for DCMS like git, mercurial etc. a destroyed working copy might be a much worse problem.

IMO, all "hidden" directories (including .git, .hg, .bzr as well) should be skipped by default.
There won't be anything we should directly change, right?

BTW, in this working copy I have a .gitignore file which could have been used to exclude .svn/.
However, this doesn't seem to work unless a .git/ directory is present as well; but this would be another issue.

@timothycrosley
Copy link
Member

@tobiasherp Thanks for reporting this issue! .git and .hg were already skipped by default and thanks to your report I’ve added .bzr and .svn. The limitation on .gitignore is one of git itself (which isort uses for the functionality) and not isort itself.

Thanks!

~Timothy

@timothycrosley timothycrosley added the enhancement New feature or request label Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants