Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imports that wrap the maximum line length and contain comments are rendered incorrectly #471

Closed
nicoddemus opened this issue Sep 13, 2016 · 2 comments
Labels
bug Something isn't working

Comments

@nicoddemus
Copy link
Contributor

Consider:

from very_long_module_name import SuperLongClassName  #@UnusedImport -- long string of comments which wrap over

Running isort on it using -m4 and forcing the use of parentheses renders this incorrect code:

from very_long_module_name import (
    SuperLongClassName  # @UnusedImport -- long string of comments which wrap over))))

(Note that isort added the ) after the comment, which generated an syntactically invalid file).

@timothycrosley timothycrosley added the bug Something isn't working label May 9, 2017
@timothycrosley
Copy link
Member

Thanks for reporting this major issue! I've resolved this issue in the development branch and prepared it for the next release.

Thanks!

~Timothy

@nicoddemus
Copy link
Contributor Author

Thanks! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants