-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it easier to use as a module rather than a script #35
Comments
I'm interested and was in fact about to take a look at that myself (which is why I was checking the issues). |
I started on this, but the requisite changes were rather extensive, and I decided I need to take some time to think through what an appropriate approach is. |
See also the current possibilities which are summarized on issue #66. |
#66 appears to offer a functional work-around. I just have to say, though, that it's not really a happy thing to have to choose between shelling out (PITA), monkey patching I hope that this was closed as a duplicate of #66, not as a wontfix. (And lest I appear just a grumpy troll who's complaining about free stuff, I should note that I have put days of work into a branch of pep8, trying to fix these issues, and that I wrote and maintain lumberlabs/pygithooks, which uses pep8 under the hood. I care, which is why I'm being vocal.) |
I consider there's interest in some enhancement. |
Upcoming release should fix it, at the cost of backward incompatibility. |
Sample use: import pep8
pep8style = pep8.StyleGuide(quiet=True)
result = pep8style.check_files(['testsuite/E27.py', 'testsuite/E12.py'])
print("Found %s errors (and warnings)" % result.total_errors) There's a shortcut when checking a single file. import pep8
fchecker = pep8.Checker('testsuite/E27.py', show_source=True)
file_errors = fchecker.check_all()
print("Found %s errors (and warnings)" % file_errors) |
Awesome! I'll play with this soon and get it integrated. Many, many thanks. |
This is great news! Will this API be documented somewhere, too? |
Patch accepted :-) See issue #105 |
Fair enough. I'll see what I can come up with :-) |
For writing (say) git/hg hooks, it'd much more convenient to be able to import pep8 as a module and use it inline, rather than having to shell out to run it as a script, capture and parse the output, etc.
This would require some fairly non-trivial changes -- e.g. there's currently lots of inline printing and a global options variable -- and there would be some api decisions to make.
I might take a look at putting together a pull request if there is interest...is there?
The text was updated successfully, but these errors were encountered: