Remove the pylint locally-enabled message suppression #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgjones
added a commit
to pgjones/wsproto
that referenced
this pull request
Dec 2, 2018
This is required till prospector is fixed, See landscapeio/prospector#309.
hence does not need suppressing. Sadly however this line errors with pylint>=2.2 and hence needs removing.
pgjones
added a commit
to pgjones/wsproto
that referenced
this pull request
Dec 2, 2018
This is required till prospector is fixed, See landscapeio/prospector#309.
pgjones
added a commit
to pgjones/wsproto
that referenced
this pull request
Dec 4, 2018
This is required till prospector is fixed, See landscapeio/prospector#309.
pgjones
added a commit
to pgjones/wsproto
that referenced
this pull request
Dec 5, 2018
This is required till prospector is fixed, See landscapeio/prospector#309.
pgjones
added a commit
to pgjones/wsproto
that referenced
this pull request
Dec 5, 2018
This is required till prospector is fixed, See landscapeio/prospector#309.
pgjones
added a commit
to pgjones/wsproto
that referenced
this pull request
Dec 5, 2018
This is required till prospector is fixed, See landscapeio/prospector#309.
chocoelho
reviewed
Dec 22, 2018
pgjones
added a commit
to python-hyper/wsproto
that referenced
this pull request
Dec 22, 2018
This is required till prospector is fixed, See landscapeio/prospector#309.
|
@pgjones this commit was cherry-picked in another PR, thanks for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of pylint 2.2 this message is no longer present in pylint, and
hence does not need suppressing. Sadly however this line errors with pylint>= 2.2 and hence needs removing.