Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update flake8/pyflakes so it understands new mypy comments #6427

Closed
legoktm opened this issue May 4, 2022 · 2 comments
Closed

Update flake8/pyflakes so it understands new mypy comments #6427

legoktm opened this issue May 4, 2022 · 2 comments
Labels
good first issue hackathon

Comments

@legoktm
Copy link
Member

legoktm commented May 4, 2022 •
edited
Loading

This is a good first issue for new contributors to take on, if you have any questions, please ask on the task or in our Gitter room!

The old version of flake8/pyflakes doesn't understand advanced mypy type comments like # type: ignore[override]. This was fixed in PyCQA/pyflakes#455 (pyflakes 2.2.0 I believe).

securedrop/store.py:32:    from tempfile import _TemporaryFileWrapper  # type: ignore # noqa: F401
securedrop/journalist_app/sessions.py:125:    def save_session(  # type: ignore[override] # noqa

(the second instance is from the unmerged sessions PR)
lb803 added a commit to lb803/securedrop that referenced this issue Dec 6, 2022
@lb803
update flake8 and remove the '# noqa' statements (as they are no long…
c6c8e3f 
…er required). Addressing the issue: freedomofpress#6427
lb803 added a commit to lb803/securedrop that referenced this issue Dec 6, 2022
@lb803
update flake8 and remove the '# noqa' statements (as they are no long…
cd171c0 
…er required). Addressing the issue: freedomofpress#6427
lb803 added a commit to lb803/securedrop that referenced this issue Dec 6, 2022
@lb803
update flake8 and remove the '# noqa' statements (as they are no long…
a15c5f9 
…er required). Addressing the issue: freedomofpress#6427
lb803 added a commit to lb803/securedrop that referenced this issue Dec 7, 2022
@lb803
update flake8 and remove the '# noqa' statements (as they are no long…
bc4f13b 
…er required). Addressing the issue: freedomofpress#6427
@lb803 lb803 mentioned this issue Dec 7, 2022
Closed
10 tasks
cfm added a commit that referenced this issue Jan 10, 2023
@cfm
update flake8 and remove the '# noqa' statements (as they are no long…
b17d972 
…er required). Addressing the issue: #6427
cfm pushed a commit that referenced this issue Jan 10, 2023
@lb803 @cfm
update flake8 and remove the '# noqa' statements (as they are no long…
a44e26d 
…er required). Addressing the issue: #6427
@rocodes
Copy link
Contributor

rocodes commented Aug 2, 2023

(This will be resolved by #6885)

@legoktm
Copy link
Member Author

legoktm commented Oct 2, 2023

Indeed, we've dropped flake8/pyflakes entirely with ruff now.

@legoktm legoktm closed this as not planned Won't fix, can't repro, duplicate, stale Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update flake8 and remove the '# noqa' statements lb803/securedrop
3 participants
@legoktm @zenmonkeykstop @rocodes