Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage for svg.py #620

Merged
merged 4 commits into from
Dec 14, 2022
Merged

Increase test coverage for svg.py #620

merged 4 commits into from
Dec 14, 2022

Conversation

yiweelan
Copy link

Increase test coverage for syg.py. #395 This relates to the lines not covered in "transform_to_rect_viewport" function.

Checklist:

  • The GitHub pipeline is OK (green),
    meaning that both pylint (static code analyzer) and black (code formatter) are happy with the changes of this PR.

  • A unit test is covering the code added / modified by this PR

  • This PR is ready to be merged

  • In case of a new feature, docstrings have been added, with also some documentation in the docs/ folder

  • A mention of the change is present in CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.

@Lucas-C Lucas-C changed the title Increase test coverage for syg.py Increase test coverage for svg.py Dec 11, 2022
test/svg/test_transform_viewport.py Outdated Show resolved Hide resolved
test/svg/test_transform_viewport.py Outdated Show resolved Hide resolved
test/svg/test_transform_viewport.py Outdated Show resolved Hide resolved
@Lucas-C
Copy link
Member

Lucas-C commented Dec 11, 2022

Thank you @yiweelan for this PR!

@allcontributors please add @yiweelan for code

@allcontributors
Copy link

@Lucas-C

I've put up a pull request to add @yiweelan! 🎉

@codecov
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

Base: 93.85% // Head: 93.99% // Increases project coverage by +0.13% 🎉

Coverage data is based on head (f774d81) compared to base (8a43f1d).
Patch has no changes to coverable lines.

❗ Current head f774d81 differs from pull request most recent head 415d295. Consider uploading reports for the commit 415d295 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #620      +/-   ##
==========================================
+ Coverage   93.85%   93.99%   +0.13%     
==========================================
  Files          24       25       +1     
  Lines        6415     6431      +16     
  Branches     1148     1148              
==========================================
+ Hits         6021     6045      +24     
+ Misses        224      220       -4     
+ Partials      170      166       -4     
Impacted Files Coverage Δ
fpdf/__init__.py 100.00% <0.00%> (ø)
fpdf/svg.py 98.30% <0.00%> (+1.69%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Lucas-C
Copy link
Member

Lucas-C commented Dec 14, 2022

@yiweelan are you OK with my minor code suggestions?

If so I'm going to merge them and then your PR

Just waiting for your feedback 😊

@yiweelan
Copy link
Author

Yes, I am okay with the code suggestion. Sorry this is my first ever pull request, so I don't really know how everything works.

@Lucas-C Lucas-C merged commit 00f9b2a into py-pdf:master Dec 14, 2022
@Lucas-C
Copy link
Member

Lucas-C commented Dec 14, 2022

No worries! Merged, thak you for your contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants