-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase test coverage for svg.py #620
Conversation
Thank you @yiweelan for this PR! @allcontributors please add @yiweelan for code |
I've put up a pull request to add @yiweelan! 🎉 |
Codecov ReportBase: 93.85% // Head: 93.99% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #620 +/- ##
==========================================
+ Coverage 93.85% 93.99% +0.13%
==========================================
Files 24 25 +1
Lines 6415 6431 +16
Branches 1148 1148
==========================================
+ Hits 6021 6045 +24
+ Misses 224 220 -4
+ Partials 170 166 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@yiweelan are you OK with my minor code suggestions? If so I'm going to merge them and then your PR Just waiting for your feedback 😊 |
Yes, I am okay with the code suggestion. Sorry this is my first ever pull request, so I don't really know how everything works. |
No worries! Merged, thak you for your contribution :) |
Increase test coverage for syg.py. #395 This relates to the lines not covered in "transform_to_rect_viewport" function.
Checklist:
The GitHub pipeline is OK (green),
meaning that both
pylint
(static code analyzer) andblack
(code formatter) are happy with the changes of this PR.A unit test is covering the code added / modified by this PR
This PR is ready to be merged
In case of a new feature, docstrings have been added, with also some documentation in the
docs/
folderA mention of the change is present in
CHANGELOG.md
By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.