Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug: font content stream not encrypted #655

Merged
merged 3 commits into from
Jan 2, 2023

Conversation

andersonhc
Copy link
Collaborator

e.g. Fixes #0

Checklist:

  • The GitHub pipeline is OK (green),
    meaning that both pylint (static code analyzer) and black (code formatter) are happy with the changes of this PR.

  • A unit test is covering the code added / modified by this PR

  • This PR is ready to be merged

  • In case of a new feature, docstrings have been added, with also some documentation in the docs/ folder

  • A mention of the change is present in CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.

@codecov
Copy link

codecov bot commented Dec 31, 2022

Codecov Report

Base: 94.04% // Head: 94.04% // No change to project coverage 👍

Coverage data is based on head (0bd2229) compared to base (8ea0b87).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #655   +/-   ##
=======================================
  Coverage   94.04%   94.04%           
=======================================
  Files          26       26           
  Lines        6715     6715           
  Branches     1189     1189           
=======================================
  Hits         6315     6315           
  Misses        230      230           
  Partials      170      170           
Impacted Files Coverage Δ
fpdf/fpdf.py 91.48% <100.00%> (ø)
fpdf/output.py 96.83% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Lucas-C
Copy link
Member

Lucas-C commented Dec 31, 2022

Thanks for the fix! 😃

Could you please add a unit test covering this case?

@Lucas-C Lucas-C merged commit 7435e7e into py-pdf:master Jan 2, 2023
@Lucas-C
Copy link
Member

Lucas-C commented Jan 2, 2023

@allcontributors please add @andersonhc for bug

@allcontributors
Copy link

@Lucas-C

I've put up a pull request to add @andersonhc! 🎉

@Lucas-C
Copy link
Member

Lucas-C commented Jan 2, 2023

Thank you @andersonhc!

I have merged your fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants