Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use objects instead of string for shas, ids, etc. arguments #2

Closed
jacquev6 opened this issue Mar 6, 2012 · 0 comments
Closed

Use objects instead of string for shas, ids, etc. arguments #2

jacquev6 opened this issue Mar 6, 2012 · 0 comments
Assignees
@jacquev6
Milestone
Version 1.0: cohe...

Comments

@jacquev6
Copy link
Member

jacquev6 commented Mar 6, 2012

No description provided.

@ghost ghost assigned jacquev6 Mar 8, 2012
jacquev6 added a commit that referenced this issue May 29, 2012
@jacquev6
Remove some easy or obsolete 'todo's
e5d5732 
See issues #2 #4 #18 #35 #36 #37
@jacquev6 jacquev6 closed this as completed Jun 2, 2012
@jacquev6 jacquev6 added the v1 label Mar 2, 2014
mfonville added a commit to mfonville/PyGithub that referenced this issue Apr 25, 2018
@mfonville
Fix github API requests after asset upload; PyGithub#2
e9b7204 
In the old code the self.__hostname would be overwritten with uploads.github.com
but it could not be correctly re-set to api.github.com after completing the upload
Create a separate connection if hostname or port differ in requestblobandcheck

in the end this became quite a large overhaul, to also make this change generic
for e.g. connecting to status.github.com and all methods
mfonville added a commit to mfonville/PyGithub that referenced this issue Apr 25, 2018
@mfonville
Fix github API requests after asset upload; PyGithub#2
a12e2b4 
In the old code the self.__hostname would be overwritten with uploads.github.com
but it could not be correctly re-set to api.github.com after completing the upload
Create a separate connection if hostname or port differ in requestblobandcheck

in the end this became quite a large overhaul, to also make this change generic
for e.g. connecting to status.github.com and all methods
mfonville added a commit to mfonville/PyGithub that referenced this issue Apr 25, 2018
@mfonville
Fix github API requests after asset upload; PyGithub#2
ab7e9e8 
In the old code the self.__hostname would be overwritten with uploads.github.com
but it could not be correctly re-set to api.github.com after completing the upload
Create a separate connection if hostname or port differ in requestblobandcheck

in the end this became quite a large overhaul, to also make this change generic
for e.g. connecting to status.github.com and all methods
mfonville added a commit to mfonville/PyGithub that referenced this issue Apr 25, 2018
@mfonville
Fix github API requests after asset upload; PyGithub#2
c6a7acb 
In the old code the self.__hostname would be overwritten with uploads.github.com
but it could not be correctly re-set to api.github.com after completing the upload
Create a separate connection if hostname or port differ in requestblobandcheck

in the end this became quite a large overhaul, to also make this change generic
for e.g. connecting to status.github.com and all methods
mfonville added a commit to mfonville/PyGithub that referenced this issue Apr 25, 2018
@mfonville
Fix github API requests after asset upload; PyGithub#2
f7cd6a2 
In the old code the self.__hostname would be overwritten with uploads.github.com
but it could not be correctly re-set to api.github.com after completing the upload
Create a separate connection if hostname or port differ in requestblobandcheck

in the end this became quite a large overhaul, to also make this change generic
for e.g. connecting to status.github.com and all methods
mfonville added a commit to mfonville/PyGithub that referenced this issue May 17, 2018
@mfonville
Fix github API requests after asset upload; PyGithub#2
e850578 
In the old code the self.__hostname would be overwritten with uploads.github.com
but it could not be correctly re-set to api.github.com after completing the upload
Create a separate connection if hostname or port differ in requestblobandcheck

in the end this became quite a large overhaul, to also make this change generic
for e.g. connecting to status.github.com and all methods
mfonville added a commit to mfonville/PyGithub that referenced this issue May 21, 2018
@mfonville
Fix github API requests after asset upload; PyGithub#2
1d311fe 
In the old code the self.__hostname would be overwritten with uploads.github.com
but it could not be correctly re-set to api.github.com after completing the upload
Create a separate connection if hostname or port differ in requestblobandcheck

in the end this became quite a large overhaul, to also make this change generic
for e.g. connecting to status.github.com and all methods
mfonville added a commit to mfonville/PyGithub that referenced this issue May 24, 2018
@mfonville
Fix github API requests after asset upload; PyGithub#2
7fbb4ca 
In the old code the self.__hostname would be overwritten with uploads.github.com
but it could not be correctly re-set to api.github.com after completing the upload
Create a separate connection if hostname or port differ in requestblobandcheck

in the end this became quite a large overhaul, to also make this change generic
for e.g. connecting to status.github.com and all methods
mfonville added a commit to mfonville/PyGithub that referenced this issue May 24, 2018
@mfonville
Fix github API requests after asset upload; PyGithub#2
56d64b5 
In the old code the self.__hostname would be overwritten with uploads.github.com
but it could not be correctly re-set to api.github.com after completing the upload
Create a separate connection if hostname or port differ in requestblobandcheck

in the end this became quite a large overhaul, to also make this change generic
for e.g. connecting to status.github.com and all methods
treee111 pushed a commit to treee111/PyGithub that referenced this issue Jan 10, 2022
@johnsc1
Merge pull request PyGithub#2 from CS481-Team-Pumpkin/test-feature-de…
7f0a239 
…lete-review

Test feature delete review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacquev6 jacquev6

Labels
None yet
Projects
None yet
Milestone
Version 1.0: coherent public interface
Development

No branches or pull requests
1 participant
@jacquev6