Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt black as code formatter #1303

Merged
merged 1 commit into from
Dec 10, 2019
Merged

Adopt black as code formatter #1303

merged 1 commit into from
Dec 10, 2019

Conversation

sfdye
Copy link
Member

@sfdye sfdye commented Nov 26, 2019

This PR proposes to use black as the code formatter.

  • Apply black to whole code base
  • Apply isort to whole code base
  • Make flake8 compatible with black
  • Update docs
  • Update PR template
  • Enforce black on CI
  • Enforce isort on CI
  • Add pre-commit
  • Add .ignore-rev-files

@codecov-io

This comment has been minimized.

@TravisBuddy

This comment has been minimized.

@sfdye sfdye added the WIP label Nov 26, 2019
@sfdye sfdye marked this pull request as ready for review November 26, 2019 15:44
@TravisBuddy

This comment has been minimized.

@TravisBuddy

This comment has been minimized.

@sfdye
Copy link
Member Author

sfdye commented Dec 4, 2019

@s-t-e-v-e-n-k Let me know if you have any strong opinion on this PR

@s-t-e-v-e-n-k
Copy link
Collaborator

@sfdye My strong opinion is this all looks amazing! If you're happy with it, I say let's land it and cut a release.

@TravisBuddy
Copy link

Hey @sfdye,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 491877c0-1b2d-11ea-b9ce-6f43500ed087

@sfdye sfdye merged commit 6ceb9e9 into master Dec 10, 2019
@sfdye sfdye deleted the black branch December 10, 2019 09:14
@sfdye
Copy link
Member Author

sfdye commented Dec 10, 2019

@s-t-e-v-e-n-k Thanks, merged into master. In the meantime, please hold off merging any open PR into master until I enforce black and isort on CI.

@s-t-e-v-e-n-k
Copy link
Collaborator

@sfdye Noted. I have a large branch to drop 2.7 support locally, but we need a release first ,so drop me a line when you're ready for me to pull the trigger for that (there's a breaking change we need to document carefully as well as stating this will be the last release to support 2.7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants