Create from template #2088
Create from template #2088
Conversation
…hub into create-from-template
Create from template
github/AuthenticatedUser.py
Outdated
| private=github.GithubObject.NotSet, | ||
| ): | ||
| """ | ||
| :calls: `POST /repos/:template_owner/:template_repo/generate <https://developer.github.com/v3/repos/#create-repository-using-a-repository-template>` |
There was a problem hiding this comment.
This is the old format and old URL for the docs.
github/AuthenticatedUser.py
Outdated
| @@ -456,18 +456,12 @@ def create_authorization( | |||
| isinstance(element, str) for element in scopes | |||
| ), scopes | |||
| assert note is github.GithubObject.NotSet or isinstance(note, str), note | |||
| assert note_url is github.GithubObject.NotSet or isinstance( | |||
There was a problem hiding this comment.
Did lint do this? These changes look unrelated.
github/AuthenticatedUser.py
Outdated
| ), hireable | ||
| assert company is github.GithubObject.NotSet or isinstance(company, str), company | ||
| assert location is github.GithubObject.NotSet or isinstance(location, str), location | ||
| assert hireable is github.GithubObject.NotSet or isinstance(hireable, bool), hireable |
There was a problem hiding this comment.
As above -- unrelated changes make this harder to review.
|
Right sorry I will redo the PR |
|
Sorry I re-requested a review without realizing the latest commit doesn't directly compare with the main branch. How do I do that? Do I squash all my commits? |
commit 6452ddf Author: Steve Kowalik <steven@wedontsleep.org> Date: Sun Oct 24 15:21:31 2021 +1100 Add Repository.rename_branch method (PyGithub#2089) The GitHub API exposes an endpoint to rename a branch, so we should support calling it. Sadly, there is not enough information to add that method to the Branch class, so expose it in the Repository object. Fixes PyGithub#1901 commit c8a945b Author: Claire Johns <42869556+johnsc1@users.noreply.github.com> Date: Sun Oct 24 00:15:31 2021 -0400 Add function to delete pending reviews on a pull request (PyGithub#1897) Add a delete method to PullRequestReview to allow dismissing them. Fixes PyGithub#1856 Co-authored-by: bagashvilit <bagashvilit@allegheny.edu> Co-authored-by: WonjoonC <chos@allegheny.edu> commit f1faf94 Author: Steve Kowalik <steven@wedontsleep.org> Date: Fri Oct 22 08:39:31 2021 +1100 Cover all code paths in search_commits (PyGithub#2087) The search_commits method was only very lightly tested, meaning over half of it was not covered. Write another test case, covering all code paths.
|
Sorry I think I made things worse by trying to solve the issue. I think i will refrain from pushing more commits for now. I think I have undo the various lint changes in 679858c but github seems to present them as changes based on the previous commit not against the main branch. Happy to redo the whole thing if you can guide me. THank you |
|
I am closing this PR and will redo at #2090 |
This is to solve #1395 and #1974
With the last commit being 652bdcc
And this is a continuation of the PR in #2012
@harismuha123 I have tried to resolve merge conflicts and hope that @s-t-e-v-e-n-k can approve this PR.