BF+ENH: FxMapper to make output order of groups deterministic (sorted by default) #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by default) Also allows for order=occurence which should sort groups in "original" order as samples within the groups appeared in the dataset. Would be valuable to see run-order dependencies after block averaging etc. Ideally that should even be default but that would change behaviour of code of many, where now order is determined by order of keys in a dictionary, thus not fully deterministic to say the least. And that is what caused daily tests breakage with Python 3
|
hm... travis failure seems to be unrelated to this PR changes |
|
ok -- if no objections from travis and anyone else comes within an hour -- would merge |
|
Looks good to me. |
nno
added a commit
that referenced
this pull request
Mar 28, 2014
BF+ENH: FxMapper to make output order of groups deterministic (sorted by default)
|
Thank you @nno! ;) though usually it is better to wait at least for travis (I have pushed changes recently) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also allows for order=occurence which should sort groups in "original" order
as samples within the groups appeared in the dataset. Would be valuable
to see run-order dependencies after block averaging etc. Ideally that should
even be default but that would change behaviour of code of many, thus not made default. Now order is determined by order of keys (uattrs) in a dictionary, thus not fully deterministic to say the least. And that is what caused daily tests breakage
with Python 3
Feel welcome to suggest naming and any other improvements.