-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cargo test
with extension-module
feature.
#1123
Conversation
Will this prevent testing pyo3 code on rust stable due to |
I don't think so, my experience just now was that cargo ignores the directive printed by the build script if it doesn't recognize it. |
@programmerjake its nice to have worries like that. So nice that pyo3 is available on stable. So much great work done this year! |
00274f1
to
b23cd69
Compare
As the cargo PR just got merged, I've rebased this and once I've confirmed it works on Rust nightly I'll update docs and propose to merge this. |
Hello! |
bc794b2
to
b0cf4cc
Compare
Hi @Spirans thanks for the check-in. I rebased this PR again just now just to confirm what I last found. Basically we need some of the build-script variables from rust-lang/cargo#8441 (comment) for this PR: specifically at the moment this uses According to rust-lang/cargo#8441 (comment) the PR which implemented I was planning to write an upstream cargo PR to implement
If you've got the time and want to push this PR through faster, would you be willing to write the cargo PR? |
@davidhewitt thank you! |
0943151
to
089ad42
Compare
089ad42
to
972b827
Compare
FYI @Spirans I just had a chance this morning to write the |
972b827
to
23b0946
Compare
23b0946
to
1a2848c
Compare
Any chance to get this cleaned up and merged? |
I will complete the cargo PR first (hopefully soon) and then once the support is there in Rust nightly I will finish this off. |
Some updates to this:
|
The linked PR seems to be merged? Can we get this done? This will be great! |
Next step here is for someone to reboot my closed PR rust-lang/cargo#9416, taking on the feedback I received and see it across the finish line. I've been meaning to do it for absolutely ages, and will do it eventually, but if anyone wants to volunteer to take that on then that'll definitely help this come sooner! |
I'll pick it. Great way to contribute for the first time to Rust repositories ! |
Brilliant, thank you! |
@davidhewitt Please check my last comment in rust-lang/cargo#10274 . I want to make sure I explained the use case correctly ;) |
It's merged now! I assume we need to wait for it to get to stable? |
Fantastic, thanks so much for getting this moving! I'd be ok with finding a way for this feature to use nightly for now (it's easy enough to ask users who want this to use Note that due to the way the I actually wrote |
Sure I can take it. |
Closing this draft, see new PR #2135 |
The excellent news is that rust-lang/cargo#8441 will resolve a lot of our existing issues with
extension-module
. The bad news is that it's not yet merged, so please wait with merging this for now!I'm not sure if this solves #904 (proc-macro crate) - we'll have to test and perhaps refine. I was able to confirm locally that
cargo test
andcargo run
are fixed with this feature.Fixes #1084
Fixes #771
Fixes #341
Fixes #340