-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cargo test
with extension-module
feature.
#2135
base: main
Are you sure you want to change the base?
Conversation
6aacb46
to
0aa471a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That closes a lot of issues 🎉 Thanks for this.
👍 thanks! It would also be worth adding |
Regarding current failure - in order to get Paramus I need interpreter config which currently is initialized only if derive configuration feature is enabled. |
|
8aef9a0
to
9d1ffb1
Compare
9d1ffb1
to
db53229
Compare
Not sure about cargo run/test - they don't seem to have any. You suggest adding a sanity test there also and running it? |
Yep exactly, can add something simple to prove it works 😊 |
I can't make an example fail on my setup for some reason (macOS, arm). Some help would be appreciated |
See #2147 |
Thanks @davidhewitt. I can reproduce it using the example you made. |
Oh, yikes. I have to confess I don't know. Might be possible to extract it from the Cargo.toml? |
But I don’t think we can extract what we’re compiling exactly?
…On Sat, 5 Feb 2022 at 19:37 David Hewitt ***@***.***> wrote:
Oh, yikes. I have to confess I don't know. Might be possible to extract it
from the Cargo.toml?
—
Reply to this email directly, view it on GitHub
<#2135 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJ2LCBCBDA6IKSKEZCJCRZLUZVN6LANCNFSM5NF3MFIQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Does checking the |
I think we might be able to use |
when merge? |
The PR isn't ready yet because I didn't think it through enough. We need to find a way to set the flags only on specific builds, which isn't as easy as one would think. I'm currently swamped by work & life so if someone wants to keep this moving they're more than welcome. |
no worries man, I don't have the expertise yet to help you out, I will try to figure out a workaround |
Fixes #1084
Fixes #771
Fixes #341
Fixes #340