Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't consider it cross-compilation when building for 32-bit Windows on 64-bit windows #1179

Merged
merged 4 commits into from
Sep 13, 2020

Conversation

alex
Copy link
Contributor

@alex alex commented Sep 12, 2020

This is a bit of an untested hack :-)

In PyO3/setuptools-rust#77 we introduced the ability to automatically build for 32-bit Windows when running a 32-bit Python on a 64-bit Windows (and Rust toolchain). The 0.12 release of pyo3 unfortunately broke this. I believe this PR may resolve it.

@davidhewitt
Copy link
Member

Thanks, nice catch. I thought our CI would catch this when I commented it seemed a possible breakage in #1095, but at the time CI suggested it was ok (and I was suprised but let it slide). Can you add a CHANGELOG entry please? (fixed section)

I will rebase the setuptools-rust github actions CI PR I had, which I guess will find the same issue.

Might give this a couple days once merged before releasing just so that 0.12.1 can include fixes for any other painful oversights!

@alex
Copy link
Contributor Author

alex commented Sep 12, 2020

Added a changelog entry. Thanks!

Copy link
Member

@kngwyu kngwyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@kngwyu kngwyu merged commit 448f0bb into PyO3:master Sep 13, 2020
@alex alex deleted the patch-1 branch September 13, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants