Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate config.py as function parameter? #4

Closed
euronion opened this issue Jan 24, 2019 · 5 comments
Closed

Integrate config.py as function parameter? #4

euronion opened this issue Jan 24, 2019 · 5 comments

Comments

@euronion
Copy link
Collaborator

The current setup method requires

  1. Downloading the source code
  2. Locally adjusting config.py
  3. Locally installing using pip

The problems I have with this:

a. It's rather cumbersome and prone to errors
b. Requires reinstallation whenever directories from config.py change
c. Is not correctly reflected in the README.rst

It seems to me it might be better to integrate the few config parameters as function parameters.

Or am I missing something?

@coroa
Copy link
Member

coroa commented Jan 25, 2019

My preferred solution would be two-layered:

  1. Have an atlite_example.yaml file in the main directory of the repository that the user is supposed to copy to ~/.atlite.yaml.
  2. Allow to override the settings there in either the call to instantiate a new Cutout object or its prepare method, as it already is the case for cutout_dir.

Feel free to have a go at it!

@euronion
Copy link
Collaborator Author

I did start working on this, however you mentioned a major update in the next days in #9 .
Does it make sense for me to continue working on thisor are we already taking the redundant road as with ERA5 again? ;-)

@coroa
Copy link
Member

coroa commented Feb 21, 2019

Hmm, i have not ripped out config.py just yet.

Ok, I’ll ignore it for now and will just pass everything as arguments explicitly and you will then have to fit your building blocks inside afterwards.

@euronion
Copy link
Collaborator Author

Covered in PR #23 .

@euronion
Copy link
Collaborator Author

Closing: The new version being prepared in #20 will provide a new way of managing the configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants