Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slicing selection not aligned on "Python standards" #308

Open
OBeaude opened this issue Jun 21, 2024 · 3 comments
Open

Slicing selection not aligned on "Python standards" #308

OBeaude opened this issue Jun 21, 2024 · 3 comments
Milestone

Comments

@OBeaude
Copy link

OBeaude commented Jun 21, 2024

Starting recently with Linopy, I discovered that, applying a slicing operation on a variable (with .loc[idx_start: idx_end] method), does select the last index idx_end, which seems non-aligned on some standards of key Python packages (e.g., numpy, pandas).

Is it directly related to xarray basis of Linopy - and in turn, not easy to be corrected, or could it evolve in a future version of Linopy?

Thank you

@FabianHofmann
Copy link
Collaborator

thank you for raising the issue, this is indeed something unexpected. this will be something for a breaking change in version 1.0

@FabianHofmann FabianHofmann added this to the v0.1 milestone Jul 5, 2024
@aurelije
Copy link
Contributor

aurelije commented Jul 9, 2024

@FabianHofmann milestone should be v1.0

@FabianHofmann FabianHofmann modified the milestones: v0.1, v1.0 Jul 9, 2024
@FabianHofmann
Copy link
Collaborator

thanks :), fixed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants