Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add live-dead syllable classification #682

Merged
merged 19 commits into from
Jun 29, 2022
Merged

Conversation

wannaphong
Copy link
Member

@wannaphong wannaphong commented Jun 29, 2022

What does this changes

Add live-dead syllable classification.

Example

from pythainlp.util import sound_syllable

print(sound_syllable("มา"))
# output: live

print(sound_syllable("เลข"))
# output: dead

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Passed code styles and structures
  • Passed code linting checks and unit test

@pep8speaks
Copy link

pep8speaks commented Jun 29, 2022

Hello @wannaphong! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 74:63: E712 comparison to False should be 'if cond is False:' or 'if not cond:'

Comment last updated at 2022-06-29 09:03:55 UTC

@wannaphong wannaphong changed the title [WIP] Add live-dead syllable [WIP] Add live-dead syllable classification Jun 29, 2022
@wannaphong wannaphong added this to the 3.1 milestone Jun 29, 2022
@wannaphong wannaphong added this to In progress in PyThaiNLP Jun 29, 2022
@wannaphong wannaphong changed the title [WIP] Add live-dead syllable classification Add live-dead syllable classification Jun 29, 2022
@wannaphong wannaphong merged commit e93ab4b into dev Jun 29, 2022
PyThaiNLP automation moved this from In progress to Done Jun 29, 2022
wannaphong added a commit that referenced this pull request Jun 29, 2022
…-classify"

This reverts commit e93ab4b, reversing
changes made to 8aaac9f.
@wannaphong wannaphong mentioned this pull request Jun 29, 2022
2 tasks
This was referenced Aug 31, 2022
wannaphong added a commit that referenced this pull request Sep 1, 2022
See [3.1 Milestone](https://github.com/PyThaiNLP/pythainlp/milestone/16).

## What is new?
### Deprecation and other API changes
#687 Remove deprecated function
- pythainlp.word_vector; doesnt_match, get_model, most_similar_cosmul, sentence_vectorizer, similarity. use WordVector class instead
- pythainlp.util.delete_tone. use pythainlp.util.remove_tonemark instead
- Remove pythainlp.util.time_time. use pythainlp.util.time_to_thaiword instead
- pythainlp.tokenize.syllable_tokenize. use pythainlp.tokenize.subword_tokenize instead

### Name Entity Tagging
- #665 Add Thai-NNER `pythainlp.tag.NNER`
- #658 Add LST20NER onnx model. It is LST20NER model to onnx model from fine-turning by [WangchanBERTa model](https://huggingface.co/airesearch/wangchanberta-base-att-spm-uncased).

### Transliteration
- #659 Add ISO 11940 transliteration
- #660 Add Thai W2P v0.2
- #686 Add wunsen
- #694 Wunsen Mandarin and Japanese update

### PyThaiNLP Corpus downloader
- #656 Add support zip/tar.gz to download corpus

### Text normalization
- #673 Add a normalising rule for Lakkhangyao ๅ

### Translate
- #674 add gpu option

### Text summarize
- #679 Add mt5 cpe kmutt thai sentence sum

### Util
- #682 Add live-dead syllable classification
- #684 Add live dead syllable classify
- #690 Add tone detector

### Other
- #689 map NG tag to PART
- #691 Remove TinyDB as a dependency
- #692 Fix notifications that newer versions of corpora are available
@wannaphong wannaphong mentioned this pull request Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
PyThaiNLP
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants