Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated function #687

Merged
merged 10 commits into from
Aug 8, 2022
Merged

Remove deprecated function #687

merged 10 commits into from
Aug 8, 2022

Conversation

wannaphong
Copy link
Member

@wannaphong wannaphong commented Jul 19, 2022

This pull request will remove deprecated function.

List deprecated function

  • pythainlp.word_vector; doesnt_match, get_model, most_similar_cosmul, sentence_vectorizer, similarity. use WordVector class instead
  • pythainlp.util.delete_tone. use pythainlp.util.remove_tonemark instead
  • Remove pythainlp.util.time_time. use pythainlp.util.time_to_thaiword instead
  • pythainlp.tokenize.syllable_tokenize. use pythainlp.tokenize.subword_tokenize instead

remove deprecated function in pythainlp.word_vector

- get_model
- doesnt_match
- most_similar_cosmul
- similarity
- sentence_vectorizer

use WordVector class instead
remove deprecated function in pythainlp.word_vector

- get_model
- doesnt_match
- most_similar_cosmul
- similarity
- sentence_vectorizer

use WordVector class instead
@coveralls
Copy link

coveralls commented Jul 19, 2022

Coverage Status

Coverage decreased (-1.6%) to 95.526% when pulling 7ac06ff on remove-deprecated-function into b0d2829 on dev.

@wannaphong wannaphong added this to the 3.1 milestone Jul 24, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jul 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wannaphong wannaphong changed the title [WIP] Remove deprecated function Remove deprecated function Jul 31, 2022
@wannaphong wannaphong merged commit 6a88f6f into dev Aug 8, 2022
This was referenced Aug 31, 2022
wannaphong added a commit that referenced this pull request Sep 1, 2022
See [3.1 Milestone](https://github.com/PyThaiNLP/pythainlp/milestone/16).

## What is new?
### Deprecation and other API changes
#687 Remove deprecated function
- pythainlp.word_vector; doesnt_match, get_model, most_similar_cosmul, sentence_vectorizer, similarity. use WordVector class instead
- pythainlp.util.delete_tone. use pythainlp.util.remove_tonemark instead
- Remove pythainlp.util.time_time. use pythainlp.util.time_to_thaiword instead
- pythainlp.tokenize.syllable_tokenize. use pythainlp.tokenize.subword_tokenize instead

### Name Entity Tagging
- #665 Add Thai-NNER `pythainlp.tag.NNER`
- #658 Add LST20NER onnx model. It is LST20NER model to onnx model from fine-turning by [WangchanBERTa model](https://huggingface.co/airesearch/wangchanberta-base-att-spm-uncased).

### Transliteration
- #659 Add ISO 11940 transliteration
- #660 Add Thai W2P v0.2
- #686 Add wunsen
- #694 Wunsen Mandarin and Japanese update

### PyThaiNLP Corpus downloader
- #656 Add support zip/tar.gz to download corpus

### Text normalization
- #673 Add a normalising rule for Lakkhangyao ๅ

### Translate
- #674 add gpu option

### Text summarize
- #679 Add mt5 cpe kmutt thai sentence sum

### Util
- #682 Add live-dead syllable classification
- #684 Add live dead syllable classify
- #690 Add tone detector

### Other
- #689 map NG tag to PART
- #691 Remove TinyDB as a dependency
- #692 Fix notifications that newer versions of corpora are available
@wannaphong wannaphong mentioned this pull request Sep 1, 2022
@wannaphong wannaphong deleted the remove-deprecated-function branch September 19, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants