Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map NG tag to PART #689

Merged
merged 1 commit into from
Jul 24, 2022
Merged

map NG tag to PART #689

merged 1 commit into from
Jul 24, 2022

Conversation

chameleonTK
Copy link
Contributor

What does this changes

map "NG" tag to "PART" when run pos tagger with corpus="lst20_ud"

What was wrong

Missing NG tag (see https://arxiv.org/abs/2008.05055)
Accoding to UnivesalDependency Guideline, it should be mapped to PART (see https://universaldependencies.org/u/pos/PART.html)

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • [/] Passed code styles and structures
  • [/] Passed code linting checks and unit test

@sonarcloud
Copy link

sonarcloud bot commented Jul 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@chameleonTK chameleonTK changed the title handle NG tag map NG tag to PART Jul 23, 2022
Copy link
Member

@wannaphong wannaphong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@wannaphong wannaphong added the enhancement enhance functionalities label Jul 23, 2022
@wannaphong wannaphong merged commit 39f88d6 into PyThaiNLP:dev Jul 24, 2022
@wannaphong wannaphong added this to the 3.1 milestone Aug 27, 2022
This was referenced Aug 31, 2022
wannaphong added a commit that referenced this pull request Sep 1, 2022
See [3.1 Milestone](https://github.com/PyThaiNLP/pythainlp/milestone/16).

## What is new?
### Deprecation and other API changes
#687 Remove deprecated function
- pythainlp.word_vector; doesnt_match, get_model, most_similar_cosmul, sentence_vectorizer, similarity. use WordVector class instead
- pythainlp.util.delete_tone. use pythainlp.util.remove_tonemark instead
- Remove pythainlp.util.time_time. use pythainlp.util.time_to_thaiword instead
- pythainlp.tokenize.syllable_tokenize. use pythainlp.tokenize.subword_tokenize instead

### Name Entity Tagging
- #665 Add Thai-NNER `pythainlp.tag.NNER`
- #658 Add LST20NER onnx model. It is LST20NER model to onnx model from fine-turning by [WangchanBERTa model](https://huggingface.co/airesearch/wangchanberta-base-att-spm-uncased).

### Transliteration
- #659 Add ISO 11940 transliteration
- #660 Add Thai W2P v0.2
- #686 Add wunsen
- #694 Wunsen Mandarin and Japanese update

### PyThaiNLP Corpus downloader
- #656 Add support zip/tar.gz to download corpus

### Text normalization
- #673 Add a normalising rule for Lakkhangyao ๅ

### Translate
- #674 add gpu option

### Text summarize
- #679 Add mt5 cpe kmutt thai sentence sum

### Util
- #682 Add live-dead syllable classification
- #684 Add live dead syllable classify
- #690 Add tone detector

### Other
- #689 map NG tag to PART
- #691 Remove TinyDB as a dependency
- #692 Fix notifications that newer versions of corpora are available
@wannaphong wannaphong mentioned this pull request Sep 1, 2022
wannaphong added a commit that referenced this pull request Sep 20, 2022
Add map NG tag to PART #689 to 3.0

Co-Authored-By: Pakawat Nakwijit <kramatk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhance functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants