adding SDR [audio] #565
adding SDR [audio] #565
Conversation
|
@SkafteNicki Hi, do you have any better ideas about the implementation of sdr_sir_sar? I think the implementation in this PR is imperfect ... |
Codecov Report
@@ Coverage Diff @@
## master #565 +/- ##
=====================================
- Coverage 95% 95% -0%
=====================================
Files 161 163 +2
Lines 5794 5881 +87
=====================================
+ Hits 5515 5593 +78
- Misses 279 288 +9 |
There was a problem hiding this comment.
Hi @quancs ,
I really do not have any good suggestions for the sdr_sir_sar function...
I guess that there is not that much to do when the base function is from another framework
for more information, see https://pre-commit.ci
Yes, you are right. |
|
@Borda Hi, do you know why the checks still do not report yet |
seems it was blocked by the conflict and still being as a draft :] |
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
for more information, see https://pre-commit.ci
|
@SkafteNicki Hi, an assertion in test_fid.py failed for the tests in this PR |
|
@quancs seems docs is fixed now |
|
@Borda Do you know why it stuck here PyTorchLightning.metrics |
that is just infra issue, restarted... 🐰 |
Before submitting
What does this PR do?
Fixes # (issue).
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃