Markup fixes and jQuery lib upgrades #16
Conversation
If you assume to be in a list you must not simply remove the tag as that results in invalid HTML, e.g. UL > INPUT.
This make SequenceWidget and MappingWidget behave more consistent. And: it's already stated in the docstring of Widget: "the default mapping and sequence widgets are in this category ['structural']". And: "Renders a sequence into a set of fields." Plus: we get rid of the invalid LABEL element pointing to the widget's DIV -- which is not valid HTML.
Instead of using custom (non-valid) attributes (e.g. prototype) and a (non-valid) SPAN inside a sequence's UL to hold min/max variables, we use HTML5 data-* attributes now. For easy access to them (and for the hotness' sake) upgrade to jQuery 1.5.2 and a more recent jQuery UI.
… behavior. See source comment for details.
Use separate DIV for the global form error message instead of just another LI. Use less classes.
|
This set of patches appears to cause one test failure in the deformdemo tests: Possibly due to JQuery differences? I didn't investigate. Hoping you can advise. |
|
mark for myself to review |
|
@ergo did you ever get a chance to review this? Is it still relevant? |
|
@kiorky It doesn't merge cleanly, so I couldn't test it but its upgrading to older versions of jquery anyways so not sure if its worth it at this point even though it would have been great |
|
Does anyone could help on this ? @hellp ? |
|
Bleh, it's my fault that this never got applied. I didn't try hard enough to evaluate it when it was submitted. The templates have changed so much in the meantime that it's probably hopeless to try to apply the patches. It might be worthwhile for us to go through the diff by-eye to see if there's anything we can salvage from it. |
|
We're moving to bootstrap templates and most of these issues will be fixed by the move. There are a couple that we might need to revisit, but that would be better after we merge bootstrap. |
Several fixes to make deform's templates validate as correct HTML (e.g. removed non-LI elements from ULs; removed custom attributes; fixed nesting of structural widgets where LIs where omitted). To make some of this work I had to upgrade to jQuery 1.5 and thus upgraded depending libs, too.