Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versioning to deps in tox.ini, or remove -rc from options for isort check in tox.ini #3602

Closed
sudhir-b opened this issue Jul 8, 2020 · 0 comments · Fixed by #3604
Closed

Comments

@sudhir-b
Copy link

sudhir-b commented Jul 8, 2020

Bug Report

With isort v5.0.0 released recently, tox -e lint is failing, because the -rc option is no longer necessary as of v5.0.0 and is not recognised as a CLI option any more for isort.

We could avoid this by specifying versions of dependencies in the tox.ini file, or by removing the -rc option where it is specified.

Removal of the option is documented here: https://github.com/timothycrosley/isort/blob/develop/docs/upgrade_guides/5.0.0.md#--recursive-or--rc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant