avoid spamming by outputting state only once when a file changes

[mmerickel]

This reduces the output to only when a file changes. However, I'm able to get it into a weird state where it keeps spamming and I haven't figured out the fix for that yet.

1. start pserve --reload
2. save a syntax error to file A.py
3. save file B.py with no changes
4. you will see a continued output of "B.py changed ..." on the console.

It doesn't happen every time but it's somewhat consistent for me (especially when B.py is pserve.py).

[digitalresistor]

👍

[domenkozar]

I'd rather print the message for all files in self.syntax_error_files here, just to be explicit what is blocking the reload.

[mmerickel]

Okay cool, I'll mess with that for a few and see how it feels. The reason I like it the way it is right now is that you only get notifications on the files that actually changed which I think it's somewhat intuitive.

[domenkozar]

But the information you're looking for is what files to fix to get reloader to work again

[domenkozar]

One nitpick, otherwise 👍

[mmerickel]

Ok new version prints out the syntax error for the new file as well as the names of all the files that have errors. Printing out all the files really doesn't feel quite right but it's not a big deal since most people should only have one or two files with errors at a time.

[mmerickel]

I created a temp file that py_compile uses to avoid changing the actual pyc file. It seems to have fixed the infinite loop issues.

[domenkozar]

Shipit

On Fri, 13 Nov 2015, 19:53 Michael Merickel notifications@github.com
wrote:

I created a temp file that py_compile uses to avoid changing the actual
pyc file. It seems to have fixed the infinite loop issues.

—
Reply to this email directly or view it on GitHub
#2049 (comment).