Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Deprecated support for Python 3.3. See #2477 #2491

Merged
merged 2 commits into from Apr 14, 2016

Conversation

stevepiercy
Copy link
Member

Closes #2477

@stevepiercy
Copy link
Member Author

ping @mmerickel @bertjwregeer anyone else?

@@ -1,6 +1,9 @@
unreleased
==========

- Deprecated support for Python 3.3.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog entry should state when support will be removed, e.g.:

- (Deprecation) Support for Python 3.3 will be removed in Pyramid 1.8.

@stevepiercy
Copy link
Member Author

Thanks @tseaver

@stevepiercy
Copy link
Member Author

Is it OK to merge this, or are there other tasks that need to be done?

@mmerickel
Copy link
Member

@tseaver any recommendations on deprecating a version other than adding a note to the changelog? Is it worth adding something at runtime or in setup.py (which isn't run when installed as a wheel)?

@tseaver
Copy link
Member

tseaver commented Apr 14, 2016

@mmerickel I wouldn't add anything beyond the changelog entry, myself.

@digitalresistor digitalresistor added this to the 1.7 milestone Apr 14, 2016
@digitalresistor
Copy link
Member

We should drop this into whatsnew-1.7 as well... outside of that I think we are good :-)

@mmerickel mmerickel merged commit 69dafc4 into Pylons:master Apr 14, 2016
@mmerickel
Copy link
Member

Sounds good, I just wanted to get a second opinion!

@stevepiercy stevepiercy deleted the feature.py33.deprecate branch April 15, 2016 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants