initial work removing pcreate #3406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevepiercy
approved these changes
Oct 31, 2018
There was a problem hiding this comment.
LGTM, with the caveat that I would like to port relevant content from docs/narr/scaffolding.rst to docs/narr/cookiecutters.rst, per Pylons/trypyramid.com#255 (comment), assuming you agree with my comment there. That could be done in a separate PR.
There may be other external references, so we should set up a redirect in RTD that aligns with porting the aforementioned content on master. We'll also need to remember to set that up for 2.0-branch, latest, and stable, when that time comes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few references to scaffolds left but not many. I think this is pretty much good to go.