Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set the minimum supported version at py35 #3547

Merged
merged 6 commits into from Dec 23, 2019

Conversation

mmerickel
Copy link
Member

I could use some help finishing this out. Need to track down other places (probably in the docs and tutorials) that python versions are referenced.

Copy link
Member

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good so far, with a couple of corrections.

I will scan the docs and make a PR to your branch.

tox.ini Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@stevepiercy stevepiercy added this to the 2.0 milestone Dec 16, 2019
@stevepiercy
Copy link
Member

By dropping 3.5, we need to revise our Python support policy.

But first the wording is kind of klunky.

At the time of a Pyramid version release, each supports all versions of Python
through the end of their lifespans.

I think the intent was:

When a major version of Pyramid is released, it is supported to work on each active version of Python at that time through the end of its lifespan.

And finally, perhaps add a sentence?

For the Pyramid 2.0 release, an exception was made to that policy to drop support of Python 3.5 ahead of its end-of-life date.
[Insert optional reasons here.]

@stevepiercy
Copy link
Member

I found this while scanning for 3.5. Candidate for removal?

# Work around a Python 3.5 issue whereby it would insert an
# extra stack frame. This should no longer be necessary in
# Python 3.5.1
last_frame = ActionInfo(*f[-1])
if last_frame.function == 'extract_stack': # pragma: no cover
f.pop()

@mmerickel
Copy link
Member Author

mmerickel commented Dec 16, 2019 via email

@stevepiercy
Copy link
Member

The docs don't need 3.5. There were a couple mentions that we support 3.5, and that was it. When I last updated the docs, I bumped up almost everything to 3.7.

I think the choice is whether you want to open the door to 3.6 features or have 3.5 block their implementation.

@mmerickel mmerickel changed the title set the minimum supported version at py36 set the minimum supported version at py35 Dec 23, 2019
@mmerickel mmerickel changed the title set the minimum supported version at py35 set the minimum supported version at py36 Dec 23, 2019
mmerickel and others added 2 commits December 23, 2019 11:55
Update docs and setup.py, remove py35, py36, add py38
Co-Authored-By: Steve Piercy <web@stevepiercy.com>
@mmerickel
Copy link
Member Author

By dropping 3.5, we need to revise our Python support policy.

I don't really want to make an exception for 3.6. If our policy is to support 3.5 then we should support 3.5.

@mmerickel mmerickel changed the title set the minimum supported version at py36 set the minimum supported version at py35 Dec 23, 2019
@mmerickel
Copy link
Member Author

the failing CI is around an unrelated issue with cookiecutter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants