py3 features #3571
Merged
py3 features #3571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmerickel
reviewed
Apr 18, 2020
mmerickel
reviewed
Apr 18, 2020
mmerickel
reviewed
Apr 18, 2020
mmerickel
requested changes
Apr 18, 2020
|
Rebased, changed this commit aadf19a |
mmerickel
approved these changes
Apr 23, 2020
|
Good stuff, thank you @slav0nic ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some addition to #3421
class Foo(object):replaced withclass Foo:,(object)make no sense in py3__nonzero__()->__bool__(), first method was removed from py3super()syntax without(class, self)/replaced with//pyramid/src/pyramid/config/predicates.py
Line 208 in 48cf45b
in py2 it returned
inttype, now in py3 -float, that looks not correct (but not critical :])__unicode__method was removed in py3, so we don't need any extra checks