Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #3577 #3579

Merged
merged 2 commits into from May 7, 2020
Merged

Backport #3577 #3579

merged 2 commits into from May 7, 2020

Conversation

stevepiercy
Copy link
Member

No description provided.

@stevepiercy
Copy link
Member Author

This PR is not the cause of the build failure. I was going to merge, but reckon that y'all might want to take a look at what's going on with lint.

I'll try to fix the broken coverage in pyramid.compat.

@stevepiercy
Copy link
Member Author

Actually I won't make an attempt to fix compat. When I ran coverage with xml -i, there were too many missed statements, and I should talk with someone before I fix something that ain't broke.

@stevepiercy stevepiercy mentioned this pull request May 4, 2020
@stevepiercy
Copy link
Member Author

stevepiercy commented May 7, 2020

Lint is now passing. However the coverage report now shows two lines as misses.

try:
    import configparser
except ImportError:
    import ConfigParser as configparser

I checked both src/pyramid/compat.py and tests/test_compat.py, but I have no idea what is the proper way to get the missed statements have coverage.

Slap a # pragma: no cover on the except?

Perhaps a new test in tests/test_config/__init__.py for configparser?

@digitalresistor
Copy link
Member

The issue is that virtualenv has pulled in configparser from PyPI, which back ports the new configparser from Python 3.x to Python 2.7.

We need to slap a pragma: no cover on that. Previously on Python 2.7 configparser would fail to import, and we would fall back to importing ConfigParser.

@digitalresistor digitalresistor merged commit 5d68745 into Pylons:1.10-branch May 7, 2020
@stevepiercy
Copy link
Member Author

Thanks for the assist @bertjwregeer !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants