Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note that starting pserve with --daemon is no longer supported #196

Merged
merged 2 commits into from
Oct 27, 2017
Merged

Add a note that starting pserve with --daemon is no longer supported #196

merged 2 commits into from
Oct 27, 2017

Conversation

prcutler
Copy link
Contributor

For Pyramid 1.9 and newer, you cannot start Pyramid with pserve
--daemon. This adds a note to the nginx deployment page to call
this out.

When I deployed my first Pyramid app this past August, the developers in IRC were kind enough to let me know that you can no longer start serve with --daemon. This adds a note to the documentation to call this out.

I don't know if it should be expanded (for Linux users) to use a systemd service instead, but that could be added / expanded to the docs.

I did successfully build this in Sphinx and it looks correct - this is my first PR to a Pylons project, please share any feedback if there is something I can do different / better.

Thanks!

For Pyramid 1.9 and newer, you cannot start Pyramid with pserve
--daemon.  This adds a note to the nginx deployment page to call
this out.
.. note::

Starting the pserve process with ``--daemon`` is no longer supported in Pyramid 1.9 and newer.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prcutler welcome to becoming a contributor!

I'm not sure if you know, the Cookbook is not official documentation but is community based. Where applicable, the Cookbook should refer to the official Pyramid (or whatever package) documentation. Sorry if this wasn't clear up front.

In this case, please remove the --daemon argument from the pserve launch commands, and update the new note to something like the following:

Daemonization of pserve was deprecated in Pyramid 1.6, then removed in Pyramid 1.8.

@prcutler
Copy link
Contributor Author

Steve,

Thanks for the clarification and feedback. I'll update with a new PR later today.

Update the PR to update starting pserve without the daemon command
and add links that daemonization was deprecated in Pyramid 1.6 and
removed in Pyramid 1.8
@prcutler
Copy link
Contributor Author

Thanks again for the feedback and I apologize for the delay in getting this updated - I've updated the PR and applied the feedback, removing the --daemon from the pserve command and changed the sentence to the recommendation with links.

It successfully built in Sphinx - please let me know if any additional changes are needed.

@stevepiercy stevepiercy merged commit 59d2c5b into Pylons:master Oct 27, 2017
@stevepiercy
Copy link
Member

Thanks @prcutler!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants