Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a note that starting pserve with --daemon is no longer supported #196

Merged
merged 2 commits into from
Oct 27, 2017
Merged

Add a note that starting pserve with --daemon is no longer supported #196

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe96591
Add a note that starting pserve with --daemon is no longer supported
prcutler Oct 13, 2017
adf7794
Update PR of daemon deprecation with feedback
prcutler Oct 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/deployment/nginx.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,10 @@ Running the pserve processes::
pserve --daemon --pid-file=pserve_5000.pid production.ini http_port=5000
pserve --daemon --pid-file=pserve_5001.pid production.ini http_port=5001

.. note::

Starting the pserve process with ``--daemon`` is no longer supported in Pyramid 1.9 and newer.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prcutler welcome to becoming a contributor!

I'm not sure if you know, the Cookbook is not official documentation but is community based. Where applicable, the Cookbook should refer to the official Pyramid (or whatever package) documentation. Sorry if this wasn't clear up front.

In this case, please remove the --daemon argument from the pserve launch commands, and update the new note to something like the following:

Daemonization of pserve was deprecated in Pyramid 1.6, then removed in Pyramid 1.8.

Step 3: Serving Static Files with Nginx (Optional)
==================================================

Expand Down