Avoid closing connections when HEAD requests have a content length
#428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
zb/fix-head-cl
branch
from
2015c16
to
20ea011
Compare
zanieb
force-pushed
the
zb/fix-head-cl
branch
from
20ea011
to
d6d764b
Compare
This was referenced Dec 21, 2023
zanieb
added a commit
to astral-sh/packse
that referenced
this pull request
Dec 21, 2023
|
The lint failure here is entirely unrelated to this pull request, it looks like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #427
When a WSGI application does not return sufficient content to satisfy the attached
Content-Lengthheader, the connection is closed to prevent the client from needlessly waiting. However, HTTP HEAD requests can set aContent-Lengthheader without any content in the body. #7 removed a warning that was incorrectly displayed when this occurs, but the connection was still being closed. As demonstrated in #427, this abrupt close can cause client-side failures. Here, the connection is no longer closed for HEAD requests withContent-Lengthset, which resolves the linked issue.