Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parameter {1} is duplicated twice thereby ignoring the third parameter #141

Closed
Sleezly opened this issue Feb 21, 2018 · 3 comments
Closed

parameter {1} is duplicated twice thereby ignoring the third parameter #141

Sleezly opened this issue Feb 21, 2018 · 3 comments

Comments

@Sleezly
Copy link
Contributor

Sleezly commented Feb 21, 2018

https://github.com/Q42/Q42.HueApi/blob/8ee5b33be17ffc0884042b24187c3050eff518af/src/Q42.HueApi/HueClient-Scenes.cs#L214
@Sleezly
Copy link
Contributor Author

Sleezly commented Feb 21, 2018

The 'lightstate' portion of the URI after the second {1} should also be changed to 'state'. See 4.3 'Modify Scene' for details:
https://developers.meethue.com/documentation/scenes-api#43_modify_scene

Example URI:
{http://192.168.x.x/api/{user_key}/scenes/{scene_id}/lights/{light_id}/state}

@Sleezly
Copy link
Contributor Author

Sleezly commented Feb 21, 2018

Pull Request has been submitted:
URI fix for ModifySceneAsync #142

Thanks.

@michielpost michielpost mentioned this issue Feb 22, 2018
Merged
@michielpost
Copy link
Owner

Fixed with #PR142 and released on NuGet Q42.HueApi 3.6.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michielpost @Sleezly