Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converter to read TID1500 and produce JSON with metadata and measurements #88

Closed
fedorov opened this issue Sep 16, 2016 · 2 comments · Fixed by #110
Closed

Converter to read TID1500 and produce JSON with metadata and measurements #88

fedorov opened this issue Sep 16, 2016 · 2 comments · Fixed by #110
Assignees
@fedorov @che85
Labels
enhancement high priority SR

Comments

@fedorov
Copy link
Member

fedorov commented Sep 16, 2016

No description provided.

@fedorov fedorov self-assigned this Sep 16, 2016
This was referenced Sep 16, 2016
Open
Merged
@che85 che85 mentioned this issue Sep 20, 2016
Closed
@che85 che85 added the SR label Oct 24, 2016
che85 added a commit to che85/dcmqi that referenced this issue Oct 28, 2016
@che85
ENH: successfully reading evidence images (composite and image librar…
866b3de 
…y) from DICOM SR (issue QIICR#88)
@che85
Copy link
Member

che85 commented Oct 29, 2016

@fedorov Seems like we missed something. How will we be able to extract that data https://github.com/QIICR/dcmqi/blob/master/doc/sr-tid1500-ct-liver-example.json#L8-L16 from the generated DICOM SR?

We are able to read the SOPInstanceUIDs and SOPClassUIDs from the Report, but that's it...

At least for reading into Slicer it would work, but won't be able to do any roundtrip for producing DICOM SR with metadata and then reading DICOM SR and producing metadata.

I only need to read the measurements, and then it's finished.

@fedorov
Copy link
Member Author

fedorov commented Oct 29, 2016

yes, I know, I thought about this when I started thinking about how to communicate context without having to reference external DICOM. For now we have no choice but accept that we won't be able to do roundtrip. Same issue applies to seg and paramaps.

che85 added a commit to che85/dcmqi that referenced this issue Nov 3, 2016
@che85
ENH: Only measurementItems missing and then it should read the comple…
0a4bf7e 
…te SR into JSON (issue QIICR#88)
che85 added a commit to che85/dcmqi that referenced this issue Nov 3, 2016
@che85
ENH: successfully reading measurements from DICOM SR (issue QIICR#88)
7c52fc6 
- also added testing
che85 added a commit to che85/dcmqi that referenced this issue Nov 4, 2016
@che85
ENH: Reading DICOM SR complete. (rwvm not included) (issue QIICR#88)
12a4aa0 
- added roundtrip test for meta information and added ignored keys for those we know are different:
  - ['activitySession', 'timePoint', 'imageLibrary', 'compositeContext']
- added additional argument for compare for ignoredKeys
@che85 che85 mentioned this issue Nov 4, 2016
Merged
che85 added a commit to che85/dcmqi that referenced this issue Nov 4, 2016
@che85
ENH: Reading n MeasurementGroups from DICOM SR into json possible (is…
442d11f 
…sue QIICR#88)
che85 added a commit to che85/dcmqi that referenced this issue Nov 7, 2016
@che85
ENH: successfully reading evidence images (composite and image librar…
f3b786f 
…y) from DICOM SR (issue QIICR#88)
che85 added a commit to che85/dcmqi that referenced this issue Nov 7, 2016
@che85
ENH: Only measurementItems missing and then it should read the comple…
ed03cde 
…te SR into JSON (issue QIICR#88)
che85 added a commit to che85/dcmqi that referenced this issue Nov 7, 2016
@che85
ENH: successfully reading measurements from DICOM SR (issue QIICR#88)
fcb964e 
- also added testing
che85 added a commit to che85/dcmqi that referenced this issue Nov 7, 2016
@che85
ENH: Reading DICOM SR complete. (rwvm not included) (issue QIICR#88)
e885a54 
- added roundtrip test for meta information and added ignored keys for those we know are different:
  - ['activitySession', 'timePoint', 'imageLibrary', 'compositeContext']
- added additional argument for compare for ignoredKeys
che85 added a commit to che85/dcmqi that referenced this issue Nov 7, 2016
@che85
ENH: Reading n MeasurementGroups from DICOM SR into json possible (is…
3c7405e 
…sue QIICR#88)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fedorov fedorov

@che85 che85

Labels
enhancement high priority SR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reading DICOM SR and creation of JSON with its attributes and measurements che85/dcmqi
2 participants
@fedorov @che85