Address timing dependence in ExperimentData.add_jobs test #1267
Conversation
Previously, the test `test_add_data_job` called `add_jobs` with two jobs and then tested that the results from `ExperimentData.data()` matched the results of the first job concatenated with the second. `ExperimentData` uses threads to handle tracking jobs. Even though these jobs are dummy jobs that take no time, `ExperimentData` would occasionally add the results from the second job before the first and then fail the results comparison. With this change, a label is attached to each result and then the results are sorted based on the label before testing against the expected results. Closes qiskit-community#1044
|
I thought I would fix this since it had the milestone on it. From what I could see, there was only one test in test_db_experiment_data.py that was affected by the issue (called |
| @@ -1073,7 +1081,7 @@ def _job2_result(): | |||
| exp_data.data(0)["counts"], [copied.data(0)["counts"], copied.data(1)["counts"]] | |||
| ) | |||
|
|
|||
| def _get_job_result(self, circ_count, has_metadata=False): | |||
| def _get_job_result(self, circ_count, label_from=0, no_metadata=False): | |||
There was a problem hiding this comment.
Why change has_metadata to no_metadata? Also, this changes the default behavior of _get_job_result() to always return metadata? I guess this didn't affect other tests.
There was a problem hiding this comment.
has_metadata was only used by one test to test the behavior when a result has metadata versus when it does not have metadata. label_from adds metadata. I thought it was cleaner for label_from to work by default, unless you requested no_metdata than to require label_from and has_metadata for that case. I don't feel strongly though. The two tests I modified are the only ones in the module that care about labels or other metadata.
…munity#1267) Previously, the test `test_add_data_job` called `add_jobs` with two jobs and then tested that the results from `ExperimentData.data()` matched the results of the first job concatenated with the second. `ExperimentData` uses threads to handle tracking jobs. Even though these jobs are dummy jobs that take no time, `ExperimentData` would occasionally add the results from the second job before the first and then fail the results comparison. With this change, a label is attached to each result and then the results are sorted based on the label before testing against the expected results. Closes qiskit-community#1044
Previously, the test
test_add_data_jobcalledadd_jobswith two jobs and then tested that the results fromExperimentData.data()matched the results of the first job concatenated with the second.ExperimentDatauses threads to handle tracking jobs. Even though these jobs are dummy jobs that take no time,ExperimentDatawould occasionally add the results from the second job before the first and then fail the results comparison. With this change, a label is attached to each result and then the results are sorted based on the label before testing against the expected results.Closes #1044