Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how-to guide bullet points #279

Merged
merged 2 commits into from
Apr 12, 2022
Merged

Fix how-to guide bullet points #279

merged 2 commits into from
Apr 12, 2022

Conversation

HuangJunye
Copy link
Contributor

@HuangJunye HuangJunye commented Apr 12, 2022

Summary

The bullet points under Specify program inputs in the two how-to guides are not rendered correctly.

This is possibly due to the bullet points are created by * instead of - in markdown. This PR replace * with - in an attempt to fix it. I need to build the website locally to verify this actually fixes the problem.

EDIT: The problem could be due to missing empty line before the bullets instead. I added that in the second commit. At least ReviewNB renders the bullet point correctly.

image

Details and comments

Fixes #

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@HuangJunye HuangJunye requested a review from y4izus April 12, 2022 11:02
@HuangJunye HuangJunye changed the title replace * with - in bullet points Fix how-to guide bullet points Apr 12, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2154469140

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.472%

Totals Coverage Status
Change from base Build 2152392054: 0.0%
Covered Lines: 2624
Relevant Lines: 3889

💛 - Coveralls

Copy link
Member

@rathishcholarajan rathishcholarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! FYI you can download the built docs from the build page under Artificats. (html_docs)
Thanks @HuangJunye!

@rathishcholarajan rathishcholarajan merged commit 1b0dcbd into Qiskit:main Apr 12, 2022
@HuangJunye HuangJunye deleted the fix-how-to-guide-bullet-points branch April 21, 2022 10:30
@rathishcholarajan rathishcholarajan added this to the 0.5.0 milestone Jun 20, 2022
blakejohnson pushed a commit to blakejohnson/qiskit-ibm-runtime that referenced this pull request May 26, 2023
* Upgrade PEC-Runtime version to fix test_user_messenger

* Upgrade pec-rutime version that contains debug info

* use aer

* missed one

Co-authored-by: jessieyu <jessieyu@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants