Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VQE argument when optimizer is not SPSA nor QNSPSA #283

Merged
merged 3 commits into from
May 2, 2022
Merged

Fix VQE argument when optimizer is not SPSA nor QNSPSA #283

merged 3 commits into from
May 2, 2022

Conversation

gyu-don
Copy link
Contributor

@gyu-don gyu-don commented Apr 13, 2022

Summary

When optimizer is not SPSA nor QNSPSA, optimizer was ignored. I fixed it.

Details and comments

I'm not sure but it may be related to #195 of this comment.

@CLAassistant
Copy link

CLAassistant commented Apr 13, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@rathishcholarajan
Copy link
Member

@Cryoris Could you please help review this?

@coveralls
Copy link

coveralls commented Apr 18, 2022 •
edited

Pull Request Test Coverage Report for Build 2258985542

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 67.563%
Totals Coverage Status
Change from base Build 2258959061: 0.09%
Covered Lines: 2637
Relevant Lines: 3903
💛 - Coveralls

@Cryoris
Copy link
Contributor

Cryoris commented Apr 26, 2022

Oh yeah this is definitely correct!

rathishcholarajan
rathishcholarajan approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@rathishcholarajan rathishcholarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot @gyu-don.

@rathishcholarajan rathishcholarajan merged commit 999d349 into Qiskit:main May 2, 2022
@rathishcholarajan rathishcholarajan added this to the 0.5.0 milestone Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rathishcholarajan rathishcholarajan rathishcholarajan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gyu-don @CLAassistant @rathishcholarajan @coveralls @Cryoris