Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add job_tags and max_execution_time to options #565

Merged
merged 3 commits into from
Oct 8, 2022
Merged

Add job_tags and max_execution_time to options #565

merged 3 commits into from
Oct 8, 2022

Conversation

jyu00
Copy link
Collaborator

@jyu00 jyu00 commented Oct 7, 2022

Summary

Adds job_tags and max_execution_time to Options. Replaces #510 (although I did copy most of the code so credits to @kt474).

Details and comments

Fixes #473

@coveralls
Copy link

coveralls commented Oct 7, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3206747835

  • 19 of 28 (67.86%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 65.601%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_runtime/qiskit_runtime_service.py 3 5 60.0%
qiskit_ibm_runtime/runtime_session.py 1 8 12.5%
Totals Coverage Status
Change from base Build 3205136756: -0.02%
Covered Lines: 3385
Relevant Lines: 5160
💛 - Coveralls

@jyu00 jyu00 requested a review from kt474 October 7, 2022 21:27
@jyu00 jyu00 mentioned this pull request Oct 7, 2022
Merged
kt474
kt474 approved these changes Oct 8, 2022
View reviewed changes
Copy link
Member

@kt474 kt474 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt474 kt474 merged commit 6c17899 into Qiskit:main Oct 8, 2022
@kt474 kt474 mentioned this pull request Oct 8, 2022
Closed
@jyu00 jyu00 deleted the tags-and-time branch October 10, 2022 12:51
@jyu00 jyu00 added the Changelog: New Feature Include in the Added section of the changelog label Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt474 kt474 kt474 approved these changes

Assignees
No one assigned
Labels
Changelog: New Feature Include in the Added section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Options should include job tags and max time
3 participants
@jyu00 @coveralls @kt474