-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for layout of the GDS/Q3D export window in the gui #938
Conversation
|
Wrapped the widgets in a GridLayout using the QT designer, so they auto scale at any resolution. The dialog size is left the same. Here are some screen shots at multiple sizes HFSSQ3DAlso related to #527 |
Wrapped the The components table in a QSortFilterProxyModel for sorting, filtering, plus Added a textChanged event to the filter box to display only specific items. #45
Good Morning, I should have created a new branch from my last pull request :( Anyway, the QComponents table now has a QSortFilterProxyModel as shown in the screen shots, you can now sort the table and filter using the text box. Moved this to a new PR. Sorry for the mistake. |
This reverts commit 71e5657.
To get linting to pass, save your python files with yapf formatting. |
run yapf -i <file> on UI python files.
Good morning. Is there a way to run the above tests from the dev env? Thanks. |
https://github.com/Qiskit/qiskit-metal/blob/main/.pylintrc Look at line 17 and 18 If these are autogenerated, the files need to be added here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this on my mac, without M1 it looked good. Did you test the re-scaling of GUI window on a windows OS?
Tested in Windows 10. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Happy to have more contributors to Qiskit Metal. Thank you for your contribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks for your contribution.
Issue #549
#549
The scaling for the GDS/Q3D/HFSS dialogs should be fixed now.
What are the issues this pull addresses (issue numbers / links)?
Issue 549: Small bug in layout of the GDS/Q3D export window in the gui
#549
Did you add tests to cover your changes (yes/no)?
No. These are UI layout changes that must be tested manually by scaling the GDS/Q3D & HFSS render dialogs.
There are no python updates. Just QT UI XML
Did you update the documentation accordingly (yes/no)?
No. I did not find documentation for QT UI XML updates.
Did you read the CONTRIBUTING document (yes/no)?
yes
Summary
Updates the QT XML UI for the GDS/Q3D & HFSS render dialogs.
Details and comments
This is my first attempt at fixing bugs in Qiskit Metal. Please review & let me know if you like them. I made simple updates to the QT XML to auto scale the GDS/Q3D & HFSS render dialogs.
Thank you for your wonderful software.