Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algorithms support utils - deprecate/remove from Qiskit #10516

Closed
woodsp-ibm opened this issue Jul 27, 2023 · 0 comments · Fixed by #10905
Closed

Algorithms support utils - deprecate/remove from Qiskit #10516

woodsp-ibm opened this issue Jul 27, 2023 · 0 comments · Fixed by #10905
Assignees
Labels
mod: algorithms Related to the Algorithms module
Milestone

Comments

@woodsp-ibm
Copy link
Member

woodsp-ibm commented Jul 27, 2023

There are a couple of util files that given the algorithms move need to be considered and probably deprecated/removed from Qiskit and be copied/refactored to qiskit-algorithms.

  1. algorithm_globals.py
  2. validation.py

I do not believe either is used outside of algorithms - these originated from Aqua and were copied over when Aqua was split/refactored into the various repos.

Update: It seems that algorithm_globals got used here too qiskit/synthesis/evolution/qdrift.py - I had not realized it had any usage outside of opflow and algorithms (also originally from Aqua). This will have to be taken care of in someway.

For 1. I had raised this yesterday on qiskit-algorithms /qiskit-community/qiskit-algorithms#21. Since algorithms use the current qiskit.utils RNG and users seed that we need to sort a way to migrate users over to a similar copy of the code in algorithms. I think we can have that copy appropriately check the seed in this and warn if its not None and update itself to use this seed for its own seed. This way I think we can transition over. Anyway something to be investigated and checked out.

For 2. I think it can simply be copied to qiskit-algorithms and the algorithms can use that instead of the Qiskit one here, this one gets deprecated and removed. Its just used for parameter validation so when you constructed an algorithm if values had ranges, min, max etc we used this to have common code and common message being raised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod: algorithms Related to the Algorithms module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants