-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constructing a Clifford from an Instruction discards phase #11330
Comments
This looks like a straight bug to me - I imagine it's just that we forget to examine the |
I do not think that this is a bug, since a Here are a few examples of Clifford identities:
and:
I would therefore suggest to close this issue. |
Oh yeah, you're right Shelly, sorry. For sure I think we ought to update the documentation to highlight this, since it's a defined part of the group. I think we might want to unify the various construction methods to ensure they behave similarly, though; at the moment, I think that making I don't think that emitting a warning would be great UX, given the class representation explicitly is phase-agnostic because of the equivalent action of the group. If it's required, perhaps we could add a Does that sound reasonable? |
I agree that it's more a documentation issue and not a bug, so I changed the label accordingly. |
I don't think we should warn, I was more meaning that we should be consistent in how we handle phases. The
Yeah, I'm roughly familiar with it and I still made the same mistake too, so definitely lets comment about exactly what |
Environment
0.25.3
3.10.12
What is happening?
If you make a
Clifford
from anInstruction
which contains a phase, the phase is discarded.How can we reproduce the issue?
What should happen?
I am not sure if this quite qualifies as a bug, but it seems like one of these would be helpful:
False
.Any suggestions?
No response
The text was updated successfully, but these errors were encountered: