Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pulse samplers into pulse_lib module #2868

Closed
taalexander opened this issue Jul 26, 2019 · 0 comments · Fixed by #2881
Closed

Move pulse samplers into pulse_lib module #2868

taalexander opened this issue Jul 26, 2019 · 0 comments · Fixed by #2881
Assignees
@taalexander
Labels
good first issue Good for newcomers mod: pulse Related to the Pulse module type: enhancement It's working, but needs polishing

Comments

@taalexander
Copy link
Contributor

What is the expected enhancement?

Samplers are only used for constructing pulses. These should be moved within the pulse_lib module.

I believe these are internal only for now and should be movable without using a shim. Thoughts @mtreinish?
@taalexander taalexander added the type: enhancement It's working, but needs polishing label Jul 26, 2019
@taalexander taalexander self-assigned this Jul 26, 2019
@taalexander taalexander added the good first issue Good for newcomers label Jul 28, 2019
@taalexander taalexander mentioned this issue Jul 29, 2019
Merged
@1ucian0 1ucian0 added the mod: pulse Related to the Pulse module label Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taalexander taalexander

Labels
good first issue Good for newcomers mod: pulse Related to the Pulse module type: enhancement It's working, but needs polishing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Moved samplers module into pulse.pulse_lib.samplers taalexander/qiskit-terra
2 participants
@1ucian0 @taalexander