Fix pip uninstall command in qiskit-neko #11826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pip uninstall command used in the qiskit neko job was missing the -y flag used to force pip to run the uninstall. Instead it was failing on the prompt to confirm the uninstall and then not uninstalling an existing install because of the failure. This has been causing us to not actually test the propsed PR because it was mixing the state of qiskit < 1.0 from pypi and >=1.0. Now that 1.0 has been released we're hitting failures in CI because all the breaking API changes we introduced in 1.0 are finally being run and the test suite is and downstream packages we were integration testing with are now broken. This commit fixes the uninstall command (although arguably it probably could be removed). The neko job will still fail with this applied as we'll need to fix it upstream but this is currently blocked on a qiskit-nature release.
|
One or more of the the following people are requested to review this:
|
mtreinish
added
type: qa
Pull Request Test Coverage Report for Build 7936918676Details
💛 - Coveralls |
jakelishman
approved these changes
Feb 17, 2024
|
@Mergifyio backport stable/0.46 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 28, 2024
The pip uninstall command used in the qiskit neko job was missing the -y flag used to force pip to run the uninstall. Instead it was failing on the prompt to confirm the uninstall and then not uninstalling an existing install because of the failure. This has been causing us to not actually test the propsed PR because it was mixing the state of qiskit < 1.0 from pypi and >=1.0. Now that 1.0 has been released we're hitting failures in CI because all the breaking API changes we introduced in 1.0 are finally being run and the test suite is and downstream packages we were integration testing with are now broken. This commit fixes the uninstall command (although arguably it probably could be removed). The neko job will still fail with this applied as we'll need to fix it upstream but this is currently blocked on a qiskit-nature release. (cherry picked from commit 12f24a7) # Conflicts: # .github/workflows/neko.yml
jakelishman
pushed a commit
that referenced
this pull request
Feb 28, 2024
The pip uninstall command used in the qiskit neko job was missing the -y flag used to force pip to run the uninstall. Instead it was failing on the prompt to confirm the uninstall and then not uninstalling an existing install because of the failure. This has been causing us to not actually test the propsed PR because it was mixing the state of qiskit < 1.0 from pypi and >=1.0. Now that 1.0 has been released we're hitting failures in CI because all the breaking API changes we introduced in 1.0 are finally being run and the test suite is and downstream packages we were integration testing with are now broken. This commit fixes the uninstall command (although arguably it probably could be removed). The neko job will still fail with this applied as we'll need to fix it upstream but this is currently blocked on a qiskit-nature release. (cherry picked from commit 12f24a7)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 28, 2024
The pip uninstall command used in the qiskit neko job was missing the -y flag used to force pip to run the uninstall. Instead it was failing on the prompt to confirm the uninstall and then not uninstalling an existing install because of the failure. This has been causing us to not actually test the propsed PR because it was mixing the state of qiskit < 1.0 from pypi and >=1.0. Now that 1.0 has been released we're hitting failures in CI because all the breaking API changes we introduced in 1.0 are finally being run and the test suite is and downstream packages we were integration testing with are now broken. This commit fixes the uninstall command (although arguably it probably could be removed). The neko job will still fail with this applied as we'll need to fix it upstream but this is currently blocked on a qiskit-nature release. (cherry picked from commit 12f24a7) Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The pip uninstall command used in the qiskit neko job was missing the -y flag used to force pip to run the uninstall. Instead it was failing on the prompt to confirm the uninstall and then not uninstalling an existing install because of the failure. This has been causing us to not actually test the propsed PR because it was mixing the state of qiskit < 1.0 from pypi and >=1.0. Now that 1.0 has been released we're hitting failures in CI because all the breaking API changes we introduced in 1.0 are finally being run and the test suite is and downstream packages we were integration testing with are now broken. This commit fixes the uninstall command (although arguably it probably could be removed). The neko job will still fail with this applied as we'll need to fix it upstream but this is currently blocked on a qiskit-nature release.
Details and comments