Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pip uninstall command in qiskit-neko (backport #11826) #11909

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 28, 2024

This is an automatic backport of pull request #11826 done by Mergify.
Cherry-pick of 12f24a7 has failed:

On branch mergify/bp/stable/0.46/pr-11826
Your branch is up to date with 'origin/stable/0.46'.

You are currently cherry-picking commit 12f24a76b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/workflows/neko.yml

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Copy link
Contributor Author

mergify bot commented Feb 28, 2024

Cherry-pick of 12f24a7 has failed:

On branch mergify/bp/stable/0.46/pr-11826
Your branch is up to date with 'origin/stable/0.46'.

You are currently cherry-picking commit 12f24a76b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/workflows/neko.yml

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot requested a review from a team as a code owner February 28, 2024 13:20
@mergify mergify bot added the conflicts used by mergify when there are conflicts in a port label Feb 28, 2024
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@github-actions github-actions bot added type: qa Issues and PRs that relate to testing and code quality Changelog: None Do not include in changelog labels Feb 28, 2024
The pip uninstall command used in the qiskit neko job was missing the -y
flag used to force pip to run the uninstall. Instead it was failing on
the prompt to confirm the uninstall and then not uninstalling an
existing install because of the failure. This has been causing us to not
actually test the propsed PR because it was mixing the state of qiskit <
1.0 from pypi and >=1.0. Now that 1.0 has been released we're hitting
failures in CI because all the breaking API changes we introduced in 1.0
are finally being run and the test suite is and downstream packages we
were integration testing with are now broken. This commit fixes the
uninstall command (although arguably it probably could be removed). The
neko job will still fail with this applied as we'll need to fix it
upstream but this is currently blocked on a qiskit-nature release.

(cherry picked from commit 12f24a7)
@jakelishman jakelishman force-pushed the mergify/bp/stable/0.46/pr-11826 branch from 8a128ae to 0573bc2 Compare February 28, 2024 13:23
@jakelishman jakelishman removed the conflicts used by mergify when there are conflicts in a port label Feb 28, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8081130803

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.03%) to 86.918%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 93.81%
crates/qasm2/src/lex.rs 3 91.94%
Totals Coverage Status
Change from base Build 8010503631: 0.03%
Covered Lines: 75058
Relevant Lines: 86355

💛 - Coveralls

@jakelishman jakelishman added this pull request to the merge queue Feb 28, 2024
Merged via the queue into stable/0.46 with commit ed53a6b Feb 28, 2024
13 checks passed
@mergify mergify bot deleted the mergify/bp/stable/0.46/pr-11826 branch February 28, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants