-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pip uninstall command in qiskit-neko (backport #11826) #11909
Conversation
Cherry-pick of 12f24a7 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
The pip uninstall command used in the qiskit neko job was missing the -y flag used to force pip to run the uninstall. Instead it was failing on the prompt to confirm the uninstall and then not uninstalling an existing install because of the failure. This has been causing us to not actually test the propsed PR because it was mixing the state of qiskit < 1.0 from pypi and >=1.0. Now that 1.0 has been released we're hitting failures in CI because all the breaking API changes we introduced in 1.0 are finally being run and the test suite is and downstream packages we were integration testing with are now broken. This commit fixes the uninstall command (although arguably it probably could be removed). The neko job will still fail with this applied as we'll need to fix it upstream but this is currently blocked on a qiskit-nature release. (cherry picked from commit 12f24a7)
8a128ae
to
0573bc2
Compare
Pull Request Test Coverage Report for Build 8081130803Details
💛 - Coveralls |
This is an automatic backport of pull request #11826 done by Mergify.
Cherry-pick of 12f24a7 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com