Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PropertySet re-use in BasePassManager.run (backport #11787) #11863

Merged
merged 1 commit into from
Feb 22, 2024

Commits on Feb 22, 2024

  1. Fix PropertySet re-use in BasePassManager.run (#11787)

    Since the genericised `PassManager`, the `PropertySet` used in the
    `WorkflowState` of a pass-manager pipeline was taken directly from the
    internal state of the `BasePassManager`.  This is set to a clean
    `PropertySet` during the pass-manager initialisation (similar to how it
    was in the previous version), but is not reset on subsequent runs.  This
    didn't cause problems in the old form because the "iterator" over tasks
    in the old form was a new `RunningPassManager` instance.
    
    Failing to generate a clean property set could lead to passes getting
    fed old analysis data when the pass manager was used more than once,
    leading to miscompilations.
    
    (cherry picked from commit 9c1accb)
    jakelishman authored and mergify[bot] committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    086aab0 View commit details
    Browse the repository at this point in the history