Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TwoLocal example: use compose instead of + #12609

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Fix TwoLocal example: use compose instead of + #12609

merged 1 commit into from
Jun 20, 2024

Conversation

Cryoris
Copy link
Contributor

@Cryoris Cryoris commented Jun 20, 2024

Summary

Fixes #12590.

@Cryoris Cryoris added documentation Something is not clear or an error documentation Changelog: None Do not include in changelog labels Jun 20, 2024
@Cryoris Cryoris requested a review from a team as a code owner June 20, 2024 07:15
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Cryoris
  • @Qiskit/terra-core
  • @ajavadia

@Cryoris Cryoris mentioned this pull request Jun 20, 2024
Closed
@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9593201588

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 12 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 89.746%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 6 92.37%
crates/qasm2/src/parse.rs 6 96.69%
Totals Coverage Status
Change from base Build 9585515412: -0.01%
Covered Lines: 63560
Relevant Lines: 70822
💛 - Coveralls

ElePT
ElePT approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@ElePT ElePT enabled auto-merge June 20, 2024 08:36
@ElePT ElePT added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Jun 20, 2024
@jakelishman
Copy link
Member

@Mergifyio backport stable/0.46 stable/1.1

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 20, 2024 •
edited
Loading

backport stable/0.46 stable/1.1

✅ Backports have been created

@ElePT ElePT added this to the 1.2.0 milestone Jun 20, 2024
@ElePT ElePT added this pull request to the merge queue Jun 20, 2024
Merged via the queue into Qiskit:main with commit 591260f Jun 20, 2024
15 checks passed
mergify bot pushed a commit that referenced this pull request Jun 20, 2024
@Cryoris @mergify
use compose instead of + (#12609)
24ea26e 
(cherry picked from commit 591260f)
mergify bot pushed a commit that referenced this pull request Jun 20, 2024
@Cryoris @mergify
use compose instead of + (#12609)
bdc53e5 
(cherry picked from commit 591260f)
This was referenced Jun 20, 2024
Merged
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jun 20, 2024
@mergify @Cryoris
use compose instead of + (#12609) (#12612)
1406341 
(cherry picked from commit 591260f)

Co-authored-by: Julien Gacon <jules.gacon@googlemail.com>
github-merge-queue bot pushed a commit that referenced this pull request Jun 20, 2024
@mergify @Cryoris
use compose instead of + (#12609) (#12611)
7666771 
(cherry picked from commit 591260f)

Co-authored-by: Julien Gacon <jules.gacon@googlemail.com>
Procatv pushed a commit to Procatv/qiskit-terra-catherines that referenced this pull request Aug 1, 2024
@Cryoris @Procatv
use compose instead of + (Qiskit#12609)
a4fd5bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelishman jakelishman jakelishman approved these changes

@ElePT ElePT ElePT approved these changes

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

TwoLocal doc strings not valid
5 participants
@Cryoris @qiskit-bot @coveralls @jakelishman @ElePT