Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Richardson error mitigation #3

Merged
merged 8 commits into from
May 20, 2020

Conversation

eggerdj
Copy link
Contributor

@eggerdj eggerdj commented Jan 22, 2020

No description provided.

@eggerdj
Copy link
Contributor Author

eggerdj commented Jan 22, 2020

Migrated from Qiskit/qiskit#768

Copy link
Member

@ajavadia ajavadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I left some minor comments. Most of my comments were on the previous PR which have been addressed. Thanks Daniel.

text/####-error-mitigation.md Outdated Show resolved Hide resolved
For example to find the stretch factors available to qubits 0, 1, and 3, the user would do `backend.available_stretch_factors([0, 1, 3])`.
Similarly, the user may query the backend to find out which qubits support a given list of stretch factors.
```
def available_qubits(self, stretch_factors: List) -> List:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To use this function one should know apriori what stretch factors there are. So I'm not sure it provides a lot of value over the methods the previous method.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct. I think available_stretch_factors will be more useful. I suggested adding available_qubits for completeness but we can also decide not to implement it and only implement it if we see a need for it later on.

text/####-error-mitigation.md Outdated Show resolved Hide resolved
eggerdj and others added 2 commits January 29, 2020 11:46
Co-Authored-By: Ali Javadi-Abhari <ajavadia@users.noreply.github.com>
@eggerdj eggerdj requested a review from ajavadia January 30, 2020 08:33
Initial commit for using the run_config object suggested by @dongreenberg
@CLAassistant
Copy link

CLA assistant check
All committers have signed the CLA.

@ajavadia ajavadia merged commit 08e0604 into Qiskit:master May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants