-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix implementation of tensor product for undirected graphs #600
Conversation
Pull Request Test Coverage Report for Build 2265616434
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Can you also add a release note describing the bug fix?
@georgios-ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we don't need a release-note. (I got confused and thought we added tensor product in the previous release).
Thanks for the updates!
This PR fixes the implementation of tensor product for undirected graphs.
Example:
However, this calculation in retworkx outputs
[((0, 0), (1, 1)), ((1, 1), (0, 0))]
.I fixed the tensor product in retworkx to output the same result as networkx.