Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web-based name-storage page can't handle names with whitespace #83

Closed
catbref opened this issue Jan 17, 2018 · 1 comment
Closed

Web-based name-storage page can't handle names with whitespace #83

catbref opened this issue Jan 17, 2018 · 1 comment

Comments

@catbref
Copy link
Collaborator

catbref commented Jan 17, 2018

When using the web-based name-storage page at http://127.0.0.1:9090/index/namestorage.html
and an entry in the "name" drop-down selection contains whitespace
then the <option>'s value attribute is malformed.

For example, with a registered name of "my name - what does it do?" the HTML is constructed thus:

<select class="form-control" id="select-name">
  <option value="my" name="" -="" what="" does="" it="" do?="">
    4.00000000 - my name - what does it do?
  </option>
</select>

The correct HTML should be:

<select class="form-control" id="select-name">
  <option value="my name - what does it do?">
    4.00000000 - my name - what does it do?
  </option>
</select>

There may be other places where this occurs so a system-wide check would be a good idea.

@catbref
Copy link
Collaborator Author

catbref commented Jan 21, 2018

This specific case fixed in v0.26.5
Some other instances also found and fixed

@catbref catbref closed this as completed Jan 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant